[PATCH] D140883: [AMDGPU] Simplify getNumFlatOffsetBits. NFC.
Ivan Kosarev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 5 07:46:25 PST 2023
kosarev added a comment.
> "expected a non-negative N-bit signed offset"
Might be worth ruminating on whether //that// would be an improvement as well before moving forward with this patch, on which, apart from noting that silicon-level bugs are probably not the best reasoning for user-exposed conceptual models, I've decided to have no opinion. :)
Things to take into consideration: that the offset bug will retire at some point and the chance for the hardware to support other offset representations in the future.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140883/new/
https://reviews.llvm.org/D140883
More information about the llvm-commits
mailing list