[PATCH] D140643: AMDGPU: Remove invalid testcase for enqueue kernel

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 07:41:46 PST 2023


arsenm added a comment.

In D140643#4023847 <https://reviews.llvm.org/D140643#4023847>, @rampitec wrote:

> It seems to remove the test when a caller is in a called function, because the called function is a kernel. But should it be an another function it shall be valid, yet I do not see such test. This is in fact what it would become after kernel call lowering. It seems worth to add such test with a non-kernel caller.

We probably should have a separate phase ordering test for the current scheme, which is not what we have here. However, I'm working on a patch to move this into clang since the comment at the top of the file explaining why this is impossible is wrong


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140643/new/

https://reviews.llvm.org/D140643



More information about the llvm-commits mailing list