[PATCH] D133340: [PowerPC][GISel]select floating point constant from TOC

Thu Jan 5 07:21:20 PST 2023

nemanjai added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/GlobalISel/fconstant-unsupported.ll:1
+; REQUIRES: asserts
+
----------------
shchenz wrote:
> nemanjai wrote:
> > arsenm wrote:
> > > This doesn't require asserts
> > Hmm, is it that producing FP constants using GISel is not supported or that GISel is not supported at all for BE and 32-bit? I imagine it is the latter.
> Yes, GISel is not supported at all for BE for now. GISel supports 32 bit, but PPC does not support 32 bit GISel for now.
Right. But I would expect that we simply reject an attempt to use GISel for `ppc32` rather than trying to turn it on and possibly selecting an incorrect instruction. Namely, treat it the same as big endian targets are treated.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133340/new/

https://reviews.llvm.org/D133340