[PATCH] D140509: [DAGCombiner][RISCV] Pre-promote (zext (abs X)) to (abs (sext X)) when X has an illegal type.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 07:04:37 PST 2023


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/iabs.ll:664
+; RV64I-NEXT:    srai a0, a0, 56
+; RV64I-NEXT:    srai a2, a0, 63
 ; RV64I-NEXT:    xor a0, a0, a2
----------------
craig.topper wrote:
> craig.topper wrote:
> > Looks like we might be missing a DAG combine to fold back to back SRA?
> Nevermind, it's because there is a freeze hiding after the first two shifts.
D136529 should fix this once I've addressed the remaining regressions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140509/new/

https://reviews.llvm.org/D140509



More information about the llvm-commits mailing list