[PATCH] D140985: [IR] Support importing modules with invalid data layouts.

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne added a comment.

The changes look good from my side. Can you add a unittest that converts an invalid DataLayout string to something legal?



================
Comment at: llvm/include/llvm/Bitcode/BitcodeReader.h:38-39
+// Callback to override the data layout string of an imported bitcode module.
+// The first argument is the target triple, the second argument the old data
+// layout string.
+typedef llvm::function_ref<std::optional<std::string>(StringRef, StringRef)>
----------------
Instead of “old” data layout string, maybe something like “data layout string from the input”?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140985/new/

https://reviews.llvm.org/D140985