[PATCH] D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend

Dominik Adamski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 05:51:08 PST 2023


domada updated this revision to Diff 486533.
domada edited the summary of this revision.
domada added a comment.

Scope of changes:

1. Refactored createTargetMachine function.

Reuse existing code.

2. Removed caching.

The existing comment about caching in createTargetMachine clearly indicates implementation obstacles. In my opinion we are allowed to create TargetMachine objects on demand because  `simd aligned` pragma with default alignment is used rarely (very few usage in OpenMP benchmarks).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138496/new/

https://reviews.llvm.org/D138496

Files:
  clang/include/clang/Basic/TargetInfo.h
  clang/lib/AST/ASTContext.cpp
  clang/lib/Basic/TargetInfo.cpp
  clang/lib/Basic/Targets/PPC.h
  clang/lib/Basic/Targets/WebAssembly.h
  clang/lib/Basic/Targets/X86.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
  llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
  llvm/include/llvm/Target/TargetMachine.h
  llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
  llvm/lib/Target/PowerPC/PPCTargetMachine.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
  llvm/lib/Target/X86/X86TargetMachine.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138496.486533.patch
Type: text/x-patch
Size: 13255 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230105/ad6be016/attachment.bin>


More information about the llvm-commits mailing list