[PATCH] D140210: [IPSCCP] Enable specialization of functions.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D140210#4028366 <https://reviews.llvm.org/D140210#4028366>, @labrinea wrote:

> In D140210#4023520 <https://reviews.llvm.org/D140210#4023520>, @labrinea wrote:
>
>> In D140210#4016893 <https://reviews.llvm.org/D140210#4016893>, @fhahn wrote:
>>
>>> It looks like CINT2017rate/502.gcc_r gets mis-compiled with LTO + PGO on
>>> AArch64 with function specialization. I reverted the patch for now.
>>
>> Thanks for looking after this. Can you share more details about your environment, or perhaps a reproducer? I haven't been able to reproduce the mis-compilation of `CINT2017rate/502.gcc_r` myself on AArch64 with LTO + PGO.
>
> Ok I can reproduce the failure on x86 if I build spec as an external benchmark for the llvm test suite.

Great! Here's what I have been using on ARM64 macOS, just in case it helps:

  lnt runtest test-suite \
      -C Release --pgo \
      --test-externals /path/to/external/spec/sources/ \
      --cmake-define TEST_SUITE_RUN_TYPE=ref --cmake-define 'TEST_SUITE_SUBDIRS=External/SPEC/CINT2017rate/502.gcc_r' \
       --build-threads=10 --sandbox "$(pwd)/tmp/" --no-timestamp --use-lit=lit \
      --cc=/path/to/bin/clang --cxx=/path/to/bin/clang++ \
      --test-suite=/path/to/llvm-test-suite/ \
      --cmake-define TEST_SUITE_BENCHMARKING_ONLY=On


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140210/new/

https://reviews.llvm.org/D140210