[llvm] 3ed1c21 - [PredicateInfo] Enable test with broken REQUIRES condition (NFC)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 03:51:35 PST 2023


Author: Nikita Popov
Date: 2023-01-05T12:51:28+01:00
New Revision: 3ed1c21ac50161e35c21574eabb28c5e1c77d6d1

URL: https://github.com/llvm/llvm-project/commit/3ed1c21ac50161e35c21574eabb28c5e1c77d6d1
DIFF: https://github.com/llvm/llvm-project/commit/3ed1c21ac50161e35c21574eabb28c5e1c77d6d1.diff

LOG: [PredicateInfo] Enable test with broken REQUIRES condition (NFC)

Add some extra uses of the comparisons, so that these do get
visited.

Added: 
    

Modified: 
    llvm/test/Transforms/Util/PredicateInfo/ordering.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/Util/PredicateInfo/ordering.ll b/llvm/test/Transforms/Util/PredicateInfo/ordering.ll
index 8d55c1ae687e6..129650dc52144 100644
--- a/llvm/test/Transforms/Util/PredicateInfo/ordering.ll
+++ b/llvm/test/Transforms/Util/PredicateInfo/ordering.ll
@@ -1,15 +1,16 @@
-; REQUIRES: assert-but-this-is-misspelled-and-should-say-asserts-but-then-the-test-case-will-fail
+; REQUIRES: asserts
 ; RUN: opt -passes=print-predicateinfo -debug < %s 2>&1 | FileCheck %s
 
 declare void @use(i32)
+declare void @use.i1(i1)
 
 ; Make sure we are visiting the values to build predicate infos for in a
 ; deterministic order.
 define i32 @test12(i32 %x, i32 %y) {
-; CHECK: Visiting i32 %x
-; CHECK: Visiting i32 %y
 ; CHECK: Visiting   %lcmp = icmp eq i32 %x, 0
+; CHECK: Visiting i32 %x
 ; CHECK: Visiting   %lcmp2 = icmp slt i32 %y, 1000
+; CHECK: Visiting i32 %y
 ; CHECK: Visiting   %lcmp3 = icmp slt i32 %y.0, 900
 ; CHECK: Visiting   %lcmp4 = icmp slt i32 %y.0.1, 700
 ; CHECK: Visiting   %lcmp5 = icmp slt i32 %y.0.1.2, 700
@@ -53,6 +54,13 @@ left_cond_true6:
   br i1 %lcmp7, label %left_cond_true7, label %left_ret
 
 left_cond_true7:
+  call void @use.i1(i1 %lcmp)
+  call void @use.i1(i1 %lcmp2)
+  call void @use.i1(i1 %lcmp3)
+  call void @use.i1(i1 %lcmp4)
+  call void @use.i1(i1 %lcmp5)
+  call void @use.i1(i1 %lcmp6)
+  call void @use.i1(i1 %lcmp7)
   ret i32 %y
 
 left_cond_false:
@@ -68,6 +76,7 @@ right:
   br i1 %rcmp, label %right_cond_true, label %right_cond_false
 
 right_cond_true:
+  call void @use.i1(i1 %rcmp)
   br label %right_ret
 
 right_cond_false:


        


More information about the llvm-commits mailing list