[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

[Sven van Haastregt via Phabricator via llvm-commits]

svenvh added a comment.

> it may be more appropriate to make these triggered off of a hidden option defaulted to off for now, or maybe based on whether or not opaque pointers are enabled

There isn't really a meaningful alternative representation for these opaque types when opaque pointers are enabled. So it sounds reasonable to gate it on whether opaque pointers are enabled.



================
Comment at: clang/include/clang-c/Index.h:30
  * The version constants for the libclang API.
  * CINDEX_VERSION_MINOR should increase when there are API additions.
  * CINDEX_VERSION_MAJOR is intended for "major" source/ABI breaking changes.
----------------
I suppose you need to bump `CINDEX_VERSION_MINOR` for the enum additions?


================
Comment at: llvm/docs/SPIRVUsage.rst:103
+
+All integer arguments take the same value as they do in the SPIR-V type name.
+For example, the OpenCL type ``image2d_depth_ro_t`` would be represented in
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141008/new/

https://reviews.llvm.org/D141008