[PATCH] D140818: [NFC][Coroutines] Build DominatorTree only once before collecting frame allocas (PR58650)

Dawid Jurczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 5 01:33:02 PST 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rG7e6c7562cbfc: [NFC][Coroutines] Build DominatorTree only once before collecting frame allocas… (authored by yurai007).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140818/new/

https://reviews.llvm.org/D140818

Files:
  llvm/lib/Transforms/Coroutines/CoroFrame.cpp


Index: llvm/lib/Transforms/Coroutines/CoroFrame.cpp
===================================================================
--- llvm/lib/Transforms/Coroutines/CoroFrame.cpp
+++ llvm/lib/Transforms/Coroutines/CoroFrame.cpp
@@ -2609,6 +2609,7 @@
 static void collectFrameAllocas(Function &F, coro::Shape &Shape,
                                 const SuspendCrossingInfo &Checker,
                                 SmallVectorImpl<AllocaInfo> &Allocas) {
+  const DominatorTree DT(F);
   for (Instruction &I : instructions(F)) {
     auto *AI = dyn_cast<AllocaInst>(&I);
     if (!AI)
@@ -2618,7 +2619,6 @@
     if (AI == Shape.SwitchLowering.PromiseAlloca) {
       continue;
     }
-    DominatorTree DT(F);
     // The code that uses lifetime.start intrinsic does not work for functions
     // with loops without exit. Disable it on ABIs we know to generate such
     // code.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140818.486499.patch
Type: text/x-patch
Size: 874 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230105/ce895dec/attachment.bin>


More information about the llvm-commits mailing list