[PATCH] D140878: [PowerPC][GISel]fcmp support

Wed Jan 4 23:49:16 PST 2023

shchenz marked an inline comment as done.
shchenz added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3720
   defm : CRNotPat<(i1 (SetCC Ty:$s1, Ty:$s2, SETUGE)),
-                  (EXTRACT_SUBREG (FCmp $s1, $s2), sub_lt)>;
+                  (EXTRACT_SUBREG (FCmp Ty:$s1, Ty:$s2), sub_lt)>;
   defm : CRNotPat<(i1 (SetCC Ty:$s1, Ty:$s2, SETGE)),
----------------
arsenm wrote:
> shchenz wrote:
> > Some workarounds for GlobalISelEmitter to handle this `setcc` pattern
> As above, I think output patterns should use classes
`Ty` can be `f32/f64/f128`, it may need another parameter for the low level register class. Let me just use MVT for now since I am working on addressing this issue in GlobalISelEmitter.cpp.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140878/new/

https://reviews.llvm.org/D140878