[PATCH] D141029: [NFC][LoopFlatten][LoopInterchange] Do not explicitly forget subloops

[Joshua Cao via Phabricator via llvm-commits]

caojoshua created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
caojoshua added reviewers: congzhe, SjoerdMeijer.
caojoshua edited reviewers, added: fhahn; removed: SjoerdMeijer.
caojoshua published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We don't need to explicitly forget subloops because forgetting parent
loops will automatically forget their subloops


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D141029

Files:
  llvm/lib/Transforms/Scalar/LoopFlatten.cpp
  llvm/lib/Transforms/Scalar/LoopInterchange.cpp


Index: llvm/lib/Transforms/Scalar/LoopInterchange.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/LoopInterchange.cpp
+++ llvm/lib/Transforms/Scalar/LoopInterchange.cpp
@@ -1240,7 +1240,6 @@
 
   // Tell SE that we move the loops around.
   SE->forgetLoop(NewOuter);
-  SE->forgetLoop(NewInner);
 }
 
 bool LoopInterchangeTransform::transform() {
Index: llvm/lib/Transforms/Scalar/LoopFlatten.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/LoopFlatten.cpp
+++ llvm/lib/Transforms/Scalar/LoopFlatten.cpp
@@ -775,9 +775,8 @@
   }
 
   // Tell LoopInfo, SCEV and the pass manager that the inner loop has been
-  // deleted, and any information that have about the outer loop invalidated.
+  // deleted, and invalidate any outer loop information.
   SE->forgetLoop(FI.OuterLoop);
-  SE->forgetLoop(FI.InnerLoop);
   SE->forgetBlockAndLoopDispositions();
   if (U)
     U->markLoopAsDeleted(*FI.InnerLoop, FI.InnerLoop->getName());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141029.486464.patch
Type: text/x-patch
Size: 1038 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230105/cac456ef/attachment.bin>