[PATCH] D137819: [XCOFF] support the overflow section (only relocation overflow is handled).

[Esme Yi via Phabricator via llvm-commits]

Esme added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:1155
+    RawPointer +=
+        alignTo(CurrAddress,
+                (*DwarfSections.begin()).DwarfSect->MCSec->getAlign()) -
----------------
shchenz wrote:
> Esme wrote:
> > shchenz wrote:
> > > We don't need the `CurrAddress` here, we can just use the `Sections.back()->Address + Sections.back()->Size`.
> > Digger also had such comment before (see comments below line 1124), we can't do that because we skip over some sections in the loop:
> > ```
> > if (Sec->Index == SectionEntry::UninitializedIndex || Sec->IsVirtual)
> >       continue;
> > ```
> Have you checked the replacement of {`RawPointer`(at line 1150) - `RawPointer`(at line 1130)} for `CurrAddress`?
Yes, I've checked that and they're not equal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137819/new/

https://reviews.llvm.org/D137819