[llvm] f8751b8 - [TargetLowering] Remove stale FIXME. NFC

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 18:42:10 PST 2023


Author: Craig Topper
Date: 2023-01-04T18:40:42-08:00
New Revision: f8751b8ee6efd4bfee9b76262b1542b139bf067a

URL: https://github.com/llvm/llvm-project/commit/f8751b8ee6efd4bfee9b76262b1542b139bf067a
DIFF: https://github.com/llvm/llvm-project/commit/f8751b8ee6efd4bfee9b76262b1542b139bf067a.diff

LOG: [TargetLowering] Remove stale FIXME. NFC

This was implemented for scalars in D140750.

Added: 
    

Modified: 
    llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp b/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
index f7e600380782..b7b5d79e0821 100644
--- a/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
@@ -6039,8 +6039,6 @@ SDValue TargetLowering::BuildUDIV(SDNode *N, SelectionDAG &DAG,
   auto BuildUDIVPattern = [&](ConstantSDNode *C) {
     if (C->isZero())
       return false;
-    // FIXME: We should use a narrower constant when the upper
-    // bits are known to be zero.
     const APInt& Divisor = C->getAPIntValue();
 
     bool SelNPQ = false;


        


More information about the llvm-commits mailing list