[PATCH] D140938: Add tests for atomic bittest with register/memory operands

Wed Jan 4 16:47:16 PST 2023

goldstein.w.n added a comment.

In D140938#4025324 <https://reviews.llvm.org/D140938#4025324>, @pengfei wrote:

> In D140938#4024958 <https://reviews.llvm.org/D140938#4024958>, @goldstein.w.n wrote:
>
>> In D140938#4024845 <https://reviews.llvm.org/D140938#4024845>, @pengfei wrote:
>>
>>> Thanks for the patch. I suggest we only test either BMI or BMI2. The difference between BMI and BMI2 is not what we care about in these patches.
>>
>> Do you mean test: [neither, bmi1 + bmi2]
>> or do you mean test [neither]?
>>
>> If the former already done:
>>
>>   ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
>>   ; RUN: llc -mtriple=i686-unknown-linux-gnu -mattr=-bmi,-bmi2 < %s | FileCheck %s --check-prefixes=X86-NOBMI2
>>   ; RUN: llc -mtriple=i686-unknown-linux-gnu -mattr=+bmi,+bmi2 < %s | FileCheck %s --check-prefixes=X86-BMI2
>>   ; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=-bmi,-bmi2 < %s | FileCheck %s --check-prefixes=X64-NOBMI2
>>   ; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+bmi,+bmi2 < %s | FileCheck %s --check-prefixes=X64-BMI2
>>   ...
>
> I mean
>
>   ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
>   ; RUN: llc -mtriple=i686-unknown-linux-gnu -mattr=+bmi2 < %s | FileCheck %s --check-prefixes=X86
>   ; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+bmi2 < %s | FileCheck %s --check-prefixes=X64
>
> Or
>
>   ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
>   ; RUN: llc -mtriple=i686-unknown-linux-gnu < %s | FileCheck %s --check-prefixes=X86
>   ; RUN: llc -mtriple=x86_64-unknown-linux-gnu < %s | FileCheck %s --check-prefixes=X64

Done in V2. (drop the BMI ones).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140938/new/

https://reviews.llvm.org/D140938