[PATCH] D140585: CodingStandards: restrict CamelCase variable names guideline to llvm/clang/clang-tools-extra/polly/bolt

Wed Jan 4 15:03:15 PST 2023

dblaikie added a comment.

In D140585#4019532 <https://reviews.llvm.org/D140585#4019532>, @mehdi_amini wrote:

> In D140585#4019417 <https://reviews.llvm.org/D140585#4019417>, @dblaikie wrote:
>
>> I'm not sure if @mehdi_amini meant their approval to be "this is good to commit in general" or "for their part, it looks OK, but other folks need buy in"?
>
> That’s how I meant it: sorry I should have left a comment about getting more approvals to reflect better consensus.

@MaskRay  Could you please revert until this ^ is addressed?

It doesn't look like https://discourse.llvm.org/t/top-level-clang-tidy-options-and-variablename-suggestion-on-codingstandards/58783 found/created more concensus that was (seems to be still is) missing from D108265 <https://reviews.llvm.org/D108265> that spawned that discourse thread.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140585/new/

https://reviews.llvm.org/D140585