[PATCH] D140930: [dsymutil] Avoid invalid keep chains due to pruning

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 13:52:18 PST 2023


avl accepted this revision.
avl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:793
+      if (Current.Flags & TF_DependencyWalk)
+        MyInfo.Prune = false;
+      else
----------------
It looks OK. Though add the comment explaining what is going on, please?
That Prune is erased because we decided to keep module forward declaration(and its dependencies) inside lookForRefDIEsToKeep.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140930/new/

https://reviews.llvm.org/D140930



More information about the llvm-commits mailing list