[PATCH] D141012: [AMDGPU] Add .uniform_work_group_size metadata to v5
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 4 13:41:19 PST 2023
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:1087-1090
+ if (Func.hasFnAttribute("uniform-work-group-size") &&
+ Func.getFnAttribute("uniform-work-group-size")
+ .getValueAsString()
+ .equals("true")) {
----------------
Don't need to query it twice, just use getFnAttribute once.
I thought there was a helper around for these awful bool string attributes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141012/new/
https://reviews.llvm.org/D141012
More information about the llvm-commits
mailing list