[PATCH] D140955: Move from llvm::makeArrayRef to ArrayRef deduction guides - llvm/ part

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 12:49:54 PST 2023


mehdi_amini added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:347
     const std::array<unsigned, 3> RegSrcOpIdx = { { 0, 2, 3 } };
-    return addMappingFromTable<3>(MI, MRI, RegSrcOpIdx, makeArrayRef(Table));
+    return addMappingFromTable<3>(MI, MRI, RegSrcOpIdx, ArrayRef(Table));
   }
----------------
It seems that in such cases we can remove the explicit `ArrayRef(...)` around `Table` here right ?

(I wonder if a clang-tidy check could detect this maybe?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140955/new/

https://reviews.llvm.org/D140955



More information about the llvm-commits mailing list