[PATCH] D138747: [Support] On Windows 11, fix an affinity mask issue on large core count machines

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 11:07:29 PST 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a minor coding style issue; you should also add a release note about the bug fix. Thank you!



================
Comment at: llvm/lib/Support/Windows/Threading.inc:164-176
+  if (::GetProcessGroupAffinity(GetCurrentProcess(), &GroupCount, nullptr)) {
+    return std::nullopt;
+  }
+  if (GetLastError() != ERROR_INSUFFICIENT_BUFFER) {
+    return std::nullopt;
+  }
+  std::vector<USHORT> GroupArray;
----------------
Minor nits for coding style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138747/new/

https://reviews.llvm.org/D138747



More information about the llvm-commits mailing list