[PATCH] D139638: [llvm-dwarfutil] Add accelerator tables to dwarfutil

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: llvm/tools/llvm-dwarfutil/DebugInfoLinker.cpp:343-353
+  SmallVector<DwarfLinkerAccelTableKind> AccelTables;
+
+  switch (Options.AccelTableKind) {
+  case DwarfUtilAccelKind::None:
+    // Nothing to do.
+    break;
+  case DwarfUtilAccelKind::DWARF:
----------------
Do we still need a list here? I presume this is a remnant of having the debug_pub{names,types} which could co-exist. It seems unlikely that without those we'll ever need more than one concurrent accelerator table type. 

This would also make it easier to improve the warning below  (line 377) and specify what type of accelerator table the input will be replaced by. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139638/new/

https://reviews.llvm.org/D139638