[PATCH] D140558: AMDGPU: Fix broken and permissive handling of printf format strings
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 4 10:10:18 PST 2023
arsenm added a comment.
In D140558#4025024 <https://reviews.llvm.org/D140558#4025024>, @sameerds wrote:
> This pass is used only by OpenCL on AMDGPU. We don't really need to handle errors at the LLVM IR level, since Clang will have already validated the printf call under the OpenCL spec. It's sufficient to just return -1 on anything invalid according to OpenCL printf spec.
>
> If we really should keep this check, can you please make sure it passes internal OpenCL builds on AMDGPU?
Passed
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140558/new/
https://reviews.llvm.org/D140558
More information about the llvm-commits
mailing list