[PATCH] D140974: [LICM][WIP] Transform and hoist select instructions if possible

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 07:39:07 PST 2023


nikic added a comment.

In D140974#4026210 <https://reviews.llvm.org/D140974#4026210>, @spatel wrote:

> We already have that fold?
> https://alive2.llvm.org/ce/z/XPZL38
>
> There is already an undo of that or something similar for FP ops on some targets, so it may need some generalization.

Ooops, you're right. I could have sworn I checked that first...

So to return to the original problem here, there may be a phase ordering issue -- can you please add a PhaseOrdering test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140974/new/

https://reviews.llvm.org/D140974



More information about the llvm-commits mailing list