[PATCH] D133340: [PowerPC][GISel]select floating point constant from TOC

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM, thanks. Some test nits



================
Comment at: llvm/test/CodeGen/PowerPC/GlobalISel/fconstant-unsupported.ll:1
+; REQUIRES: asserts
+
----------------
This doesn't require asserts


================
Comment at: llvm/test/CodeGen/PowerPC/GlobalISel/fconstant-unsupported.ll:3
+
+; RUN: not --crash llc -mtriple=powerpc-unknown-linux-gnu -global-isel \
+; RUN:   -o -verify-machineinstrs - < %s 2>&1 | FileCheck %s --check-prefix=BE
----------------
I prefer -global-isel as the first llc argument


================
Comment at: llvm/test/CodeGen/PowerPC/GlobalISel/fconstant-unsupported.ll:6
+; RUN: not --crash llc -mtriple=powerpcle-unknown-linux-gnu -global-isel \
+; RUN:   -o -verify-machineinstrs - < %s 2>&1 | FileCheck %s --check-prefix=BIT32
+
----------------
Drop -verify-machineinstrs, you only want the legalization error anyway


================
Comment at: llvm/test/CodeGen/PowerPC/GlobalISel/fconstant-unsupported.ll:12
+; handled by now.
+; BIT32: LLVM ERROR: unable to legalize instruction: %0:_(s64) = G_LOAD{{.*}}align 4
+
----------------
Don't hardcode the register number


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133340/new/

https://reviews.llvm.org/D133340