[PATCH] D140782: [RISCV] Teach lowerCTLZ_CTTZ_ZERO_UNDEF to handle i32 vectors with conversion to f32 vectors.

Yeting Kuo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 06:57:09 PST 2023


fakepaper56 marked an inline comment as done.
fakepaper56 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td:143
 ]>;
+def SDT_RISCVI2FPOp_RM_VL  : SDTypeProfile<1, 4, [
+  SDTCisFP<0>, SDTCisInt<1>, SDTCisSameNumEltsAs<0, 1>,
----------------
craig.topper wrote:
> fakepaper56 wrote:
> > I have tried to use similar naming as `SDT_RISCVVecCvtX2FOp_VL` `riscv_vfcvt_rm_x_f_vl` used. But I confused that `SDT_RISCVVecCvtX2FOp_VL` looks like that it's for converting x to f rather than converting f to x.
> You're right. I did name that badly. I'll fix it.
Thank you. If you are busy, I could open a revision to rename `SDT_RISCVVecCvtX2FOp_VL` to `SDT_RISCVVecCvtF2XOp_VL` by myself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140782/new/

https://reviews.llvm.org/D140782



More information about the llvm-commits mailing list