[PATCH] D140111: [lld][wasm] Split __wasm_apply_data_relocs when it exceeds the function size limit

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 06:33:05 PST 2023


sbc100 added a comment.

I still have some concerns here.  Firstly, I think it should be possible to do this without generating the tail function when its not needed.   Can't applyDataRelocsTail simply be null in this case?

Secondly I'm not sure about and a new source file and header, or the name of the those new files, but thats mostly aesthetic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140111/new/

https://reviews.llvm.org/D140111



More information about the llvm-commits mailing list