[PATCH] D139000: [AMDGPU] Clear bodies of function with incompatible features

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 06:26:06 PST 2023


Joe_Nash accepted this revision.
Joe_Nash added a comment.
This revision is now accepted and ready to land.

In D139000#4025199 <https://reviews.llvm.org/D139000#4025199>, @Pierre-vh wrote:

> Last time I checked (before the holidays), it builds fine without the patch reverted. I can try reverting the patch later when this lands perhaps? Or should it be done at the same time?
> For reference the only build issues I experienced where with hard f64 functions like llvm.sin.f64, which are apparently not (well) supported if I understand correctly

I'm fine with you landing this patch then reverting the V_ILLEGAL patch later.

LGTM! Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139000/new/

https://reviews.llvm.org/D139000



More information about the llvm-commits mailing list