[PATCH] D140964: [GlobalISel] Don't switch opcodes in MIRBuilder::buildInstr

Wed Jan 4 03:23:29 PST 2023

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

> This patch simplifies the API of MachineIRBuilder so that the
> buildInstr method does the least surprising thing (i.e. builds an instruction
> with the specified opcode) and only the convenience buildX methods
> (buildMerge etc) are allowed freedom over which opcode to use.

I like this!

Does this patch actually fix any missed CSE opportunities?

I wonder if we could get rid of buildMerge altogether, in favour of separate buildMergeValues / buildConcatVectors / buildBuildVector functions.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140964/new/

https://reviews.llvm.org/D140964