[PATCH] D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In D127115#4024728 <https://reviews.llvm.org/D127115#4024728>, @deadalnix wrote:

> @RKSimon Yes, I can do that in January. There is one thing I'm not sure of, where do we put the bar for this to be merged? If we want no regression at all, this is going to be very difficult to get it past the line.

I'd still prefer that all the regressions are addressed before approval - even if you have to create a patch series with follow up fixes. A patch like this is likely to have additional side effects that will be reported later and will take a a while to address - the more regressions we fix first the less stressful that will be. It'd be very annoying if this patch gets stuck in a revert-recommit cycle as the premise is sound (and should've been done years ago).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115