[llvm] ba87448 - [llvm-exegesis] Remove functional test from unit tests

Guillaume Chatelet via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 02:39:53 PST 2023


Author: Guillaume Chatelet
Date: 2023-01-04T10:39:39Z
New Revision: ba874483137dacf3c4febbf8883a766b6191f529

URL: https://github.com/llvm/llvm-project/commit/ba874483137dacf3c4febbf8883a766b6191f529
DIFF: https://github.com/llvm/llvm-project/commit/ba874483137dacf3c4febbf8883a766b6191f529.diff

LOG: [llvm-exegesis] Remove functional test from unit tests

As discussed offline, let's remove this one as it's hard to test on the build bots.

Differential Revision: https://reviews.llvm.org/D140898

Added: 
    

Modified: 
    llvm/unittests/tools/llvm-exegesis/CMakeLists.txt

Removed: 
    llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp


################################################################################
diff  --git a/llvm/unittests/tools/llvm-exegesis/CMakeLists.txt b/llvm/unittests/tools/llvm-exegesis/CMakeLists.txt
index 5dbceed09f462..58e514a11ad33 100644
--- a/llvm/unittests/tools/llvm-exegesis/CMakeLists.txt
+++ b/llvm/unittests/tools/llvm-exegesis/CMakeLists.txt
@@ -14,7 +14,6 @@ set(LLVM_LINK_COMPONENTS
 set(exegesis_sources
   BenchmarkRunnerTest.cpp
   ClusteringTest.cpp
-  PerfHelperTest.cpp
   ProgressMeterTest.cpp
   RegisterValueTest.cpp
   )

diff  --git a/llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp b/llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp
deleted file mode 100644
index f4a07e8ebf5c3..0000000000000
--- a/llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp
+++ /dev/null
@@ -1,42 +0,0 @@
-//===-- PerfHelperTest.cpp --------------------------------------*- C++ -*-===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-#include "PerfHelper.h"
-#include "llvm/Config/config.h"
-#include "gmock/gmock.h"
-#include "gtest/gtest.h"
-
-namespace llvm {
-namespace exegesis {
-namespace pfm {
-namespace {
-
-using ::testing::IsEmpty;
-using ::testing::Not;
-
-TEST(PerfHelperTest, FunctionalTest) {
-#ifdef HAVE_LIBPFM
-  ASSERT_FALSE(pfmInitialize());
-  PerfEvent Event("CYCLES:u");
-  ASSERT_TRUE(Event.valid());
-  EXPECT_EQ(Event.name(), "CYCLES:u");
-  EXPECT_THAT(Event.getPfmEventString(), Not(IsEmpty()));
-  Counter Cnt(std::move(Event));
-  Cnt.start();
-  Cnt.stop();
-  Cnt.read();
-  pfmTerminate();
-#else
-  ASSERT_TRUE(pfmInitialize());
-#endif
-}
-
-} // namespace
-} // namespace pfm
-} // namespace exegesis
-} // namespace llvm


        


More information about the llvm-commits mailing list