[PATCH] D140846: [NVPTX] Fix NVPTX lowering of frem when denominator is infinite.

[Benjamin Chetioui via Phabricator via llvm-commits]

bchetioui marked 2 inline comments as done.
bchetioui added a comment.

Thanks for the review, @tra and @herhut!



================
Comment at: llvm/lib/Target/NVPTX/NVPTXInstrInfo.td:604
+
+// FIXME: Missing slct
+
----------------
tra wrote:
> Nit: It's more of a TODO, IMO. :-)
> 
> I wonder if the instruction actually provides any benefit over `cmp`+`selp` on the SASS level. I suspect that it probably does not, and implementing it would just give us a bit nicer PTX w/o much of an effect on the actual GPU code.
Done. (Though this is not really part of the change, I moved this block from below to satisfy requirements re. definition order. :-))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140846/new/

https://reviews.llvm.org/D140846