[PATCH] D139780: [AMDGPU] Unify divergent nodes if the PostDom tree has one root

Tue Jan 3 23:16:45 PST 2023

ruiling accepted this revision.
ruiling added a comment.

I think it is good to go. Thanks!

================
Comment at: llvm/test/CodeGen/AMDGPU/agpr-copy-no-free-registers.ll:657
+; GFX908-NEXT:    s_mov_b64 s[22:23], -1
 ; GFX908-NEXT:    s_branch .LBB3_4
 ;
----------------
gandhi21299 wrote:
> ruiling wrote:
> > ruiling wrote:
> > > Why there is no DummyReturnBlock for GFX908?
> > Did you try to get the answer for the question? It sounds strange we get different behavior for gfx908 and gfx90A here.
> In gfx908, the block is eliminated much later in the pipeline which does not happen in gfx90a.
Thanks for taking a second look!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139780/new/

https://reviews.llvm.org/D139780