[PATCH] D140580: [SLP]Do not emit many extractelements, reuse the single one emitted.

Tue Jan 3 22:37:41 PST 2023

uabelho added a comment.

In D140580#4023578 <https://reviews.llvm.org/D140580#4023578>, @ABataev wrote:

> In D140580#4023051 <https://reviews.llvm.org/D140580#4023051>, @anna wrote:
>
>> In D140580#4022871 <https://reviews.llvm.org/D140580#4022871>, @ABataev wrote:
>>
>>> In D140580#4022462 <https://reviews.llvm.org/D140580#4022462>, @uabelho wrote:
>>>
>>>> We also see crashes with this. Reproduceable with
>>>>
>>>>   opt -passes="slp-vectorizer" -mtriple=aarch64--linux-gnu bbi-77341.ll -o /dev/null
>>>>
>>>> F26081559: bbi-77341.ll <https://reviews.llvm.org/F26081559>
>>>
>>> Why those constant insructions were not folded away by Instcombiner?
>>
>> We used fuzzer as well. Also, functional correctness of a pass is orthogonal to whether other passes produce optimal instructions.
>
> Must be fixed in 26fec4e845a833214d2b0036ea90f1b1c2418d50 <https://reviews.llvm.org/rG26fec4e845a833214d2b0036ea90f1b1c2418d50>

Yep, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140580/new/

https://reviews.llvm.org/D140580