[PATCH] D140558: AMDGPU: Fix broken and permissive handling of printf format strings

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds added a comment.

This pass is used only by OpenCL on AMDGPU. We don't really need to handle errors at the LLVM IR level, since Clang will have already validated the printf call under the OpenCL spec. It's sufficient to just return -1 on anything invalid according to OpenCL printf spec.

If we really should keep this check, can you please make sure it passes internal OpenCL builds on AMDGPU?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140558/new/

https://reviews.llvm.org/D140558