[PATCH] D139780: [AMDGPU] Unify divergent nodes if the PostDom tree has one root

Anshil Gandhi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 20:43:01 PST 2023


gandhi21299 added a comment.

Thanks Matt for the approval! How does the patch look @ruiling ?



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUUnifyDivergentExitNodes.cpp:109
   // This is a cluster of orthogonal Transforms
   AU.addPreservedID(LowerSwitchID);
   FunctionPass::getAnalysisUsage(AU);
----------------
arsenm wrote:
> We should have a required LowerSwitchID too
I will have a seperate patch for that, it seems to be causing difficulties when the pass manager schedules UnifyDivergentExitNodes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139780/new/

https://reviews.llvm.org/D139780



More information about the llvm-commits mailing list