[PATCH] D140811: [DAGCombiner][X86] `visitVECTOR_SHUFFLE()`: splats with a single non-undef element are not splats

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 16:38:31 PST 2023


lebedev.ri added a comment.

In D140811#4023270 <https://reviews.llvm.org/D140811#4023270>, @RKSimon wrote:

> Sorry for the delay - I'm slowly returning from Christmas break.



> I think if we can address the horizontal-op regressions

Err. As far as i was concerned, the horisontal-op changes *weren't* regressions,
because they all happen for the run lines where horisontal math is slow.
Do we actually want those to remain HOps?

> then the other cases are pretty trivial to address - tweaking canonicalizeShuffleMaskWithHorizOp might help us.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140811/new/

https://reviews.llvm.org/D140811



More information about the llvm-commits mailing list