[PATCH] D140841: [DWARFLinkerNext] Add StringPool class.

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

In D140841#4023979 <https://reviews.llvm.org/D140841#4023979>, @dblaikie wrote:

> We probably already have a few StringPools kicking around in LLVM - a multithreaded one sounds like something LLDB already uses (it has a core StringPool for interning strings) - any chance the LLDB one could be sunk into LLVM and reused for your use case as well, for instance?

I am not sure that found the right piece of lldb code:

"lldb/Core/UniqueCStringMap.h" - this one is not multi-thread.
"lldb/Core/ThreadSafeDenseMap.h" - this one looks to be not effective in heavy multi-thread environment. It locks the whole table for every operation. In heavy multi-thread environment threads would wait each another.

Thus, it looks like both of them are not good candidate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140841/new/

https://reviews.llvm.org/D140841