[PATCH] D140646: [AMDGPU][NFC] DWARF extensions minor update

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 15:46:03 PST 2023


t-tye added inline comments.


================
Comment at: llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst:2174
+``DW_ASPACE_none`` is defined as the target architecture default address space
+See :ref:`amdgpu-dwarf-segment_addresses``.
 
----------------
scott.linder wrote:
> In most places we seem to parenthesize this kind of reference, do we want to do the same here? If not, should this be separated from the first bit by a comma or semicolon?
There seems to be a mix of either a parenthesized and separate sentence. Added the missing period to this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140646/new/

https://reviews.llvm.org/D140646



More information about the llvm-commits mailing list