[PATCH] D140581: [NVPTX] Enforce minumum alignment of 4 for byval parametrs in a function prototype

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

Looks good overall.



================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:1428
+    // emitFunctionParamList() for details.
+    ParamByValAlign = std::max(ParamByValAlign, Align(4));
+
----------------
This seems to be the same adjustment we do in `LowerCall` below. Perhaps we can consolidate alignment calculation into a single helper function.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:1578
       // emitFunctionParamList() for details.
       ArgAlign = std::max(ArgAlign, Align(4));
       if (IsVAArg)
----------------
Here...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140581/new/

https://reviews.llvm.org/D140581