[PATCH] D136302: [DirectX backend] Support typed buffer load/store.

Xiang Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 15:07:38 PST 2023


python3kgae added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILTypedBufferLowering.cpp:55
+        // FIXME: use createHandle generated in clangCodeGen.
+        // See https://github.com/llvm/llvm-project/issues/58031.
+        SI->eraseFromParent();
----------------
beanz wrote:
> Is this particularly complicated?
Might be complicated when support array.
Better do this after resource array is supported.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136302/new/

https://reviews.llvm.org/D136302



More information about the llvm-commits mailing list