[PATCH] D140924: [SelectionDAG][GlobalISel] Move even divisor optimization for division by constant into UnsignedDivideUsingMagic implementation. NFC

Tue Jan 3 14:55:45 PST 2023

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

Nice cleanup!
Looks good to me.
Thanks.

================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:4965
-
     unsigned SelNPQ;
     if (!magics.IsAdd || Divisor.isOneValue()) {
----------------
While we are around, can we perhaps give `NPQ` a more understandable name, or at least a comment somewhere as to what it stands for?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140924/new/

https://reviews.llvm.org/D140924