[PATCH] D118943: [DAGCombiner] Fix dependency analysis in checkMergeStoreCandidatesForDependencies

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 14:27:56 PST 2023


bjope added a comment.

In D118943#4023264 <https://reviews.llvm.org/D118943#4023264>, @RKSimon wrote:

> @bjope This has been identified as the cause of a major compile time regression - https://github.com/llvm/llvm-project/issues/59800 - please can you take a look?

Thanks for the heads up @RKSimon.
IIRC this fix was done to avoid some ICE (LLVM unreachable). So the fix was just to make the analysis correct.
I can take a look to see if I can find something to improve.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118943/new/

https://reviews.llvm.org/D118943



More information about the llvm-commits mailing list