[PATCH] D140147: [RISCV][InsertVSETVLI] Rewrite scalar insert forward rule in terms of demanded fields

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 14:24:08 PST 2023


reames added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:235
 
   // For vmv.s.x and vfmv.s.f, there is only two behaviors, VL = 0 and VL > 0.
+  if (isScalarMoveInstr(MI)) {
----------------
craig.topper wrote:
> while you're here
> 
> "is only" -> "are only"
Typo fix done separately in 6df5464a4 to get both copies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140147/new/

https://reviews.llvm.org/D140147



More information about the llvm-commits mailing list