[PATCH] D136302: [DirectX backend] Support typed buffer load/store.

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

A few questions. Does this pass work with handles passed as parameters to functions? What about different functions that refer to the same global? Does that result in multiple `createHandle` calls?



================
Comment at: llvm/lib/Target/DirectX/DXILTypedBufferLowering.cpp:55
+        // FIXME: use createHandle generated in clangCodeGen.
+        // See https://github.com/llvm/llvm-project/issues/58031.
+        SI->eraseFromParent();
----------------
Is this particularly complicated?


================
Comment at: llvm/lib/Target/DirectX/DXILTypedBufferLowering.cpp:84
+        Hdl = DXILB.createCreateHandle(
+            static_cast<unsigned>(hlsl::ResourceClass::UAV), RangeID, UAVIndex,
+            false);
----------------
Should this cast be to `int8_t` instead since that is the argument type?


================
Comment at: llvm/lib/Target/DirectX/DXILTypedBufferLowering.cpp:106
+        } else if (isa<VectorType>(Ty)) {
+          // Only support fixed vectory type.
+          auto *VT = cast<FixedVectorType>(Ty);
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136302/new/

https://reviews.llvm.org/D136302