[PATCH] D139871: [WebAssembly] Replace LOAD_SPLAT with SPLAT_VECTOR

Tue Jan 3 12:39:10 PST 2023

tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: llvm/test/CodeGen/WebAssembly/fpclamptosat_vec.ll:302
 ; CHECK-NEXT:    i32x4.min_s
-; CHECK-NEXT:    v128.const -32768, -32768, 0, 0
+; CHECK-NEXT:    v128.const -32768, -32768, -32768, -32768
 ; CHECK-NEXT:    i32x4.max_s
----------------
luke wrote:
> This is as close as I could get to making it an NFC, by adding a pattern to select `v128.const` for splats on immediates.
> The undef fields are no longer 0, but I initially tried to preserve it by only conditionally selecting `splat_vector`. But this meant changing DAGCombine and adding a target lowering info hook, and caused some other cases to fail.
non-zero undefs seem fine to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139871/new/

https://reviews.llvm.org/D139871