[PATCH] D140202: [lld][ARM][2/3]Big Endian support - Word invariant support

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 12:28:36 PST 2023


MaskRay added a comment.

In D140202#4023008 <https://reviews.llvm.org/D140202#4023008>, @M-Plichta wrote:

> In D140202#4016163 <https://reviews.llvm.org/D140202#4016163>, @MaskRay wrote:
>
>> Please answer why --be8 and --be32 are added and what the references are.
>
> Some documentation for --be8: https://sourceware.org/binutils/docs/ld/ARM.html and https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
> As far as I'm aware, --be32 is deprecated but needed to be added for backwards compatibility.
>
> The --be8 and --be32 were added at the same time because this patch is a precursor for the patch that adds --be8 support. You're right though, it does not belong in this patch.
>
> Thanks.

Removing the options and this patch is fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140202/new/

https://reviews.llvm.org/D140202



More information about the llvm-commits mailing list