[PATCH] D140460: [RISCV][MC] Add support for experimental zfa extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/MC/RISCV/rv64zfa-valid.s:1
+# RUN: llvm-mc %s -triple=riscv64 -mattr=+experimental-zfa,+d,+zfh -riscv-no-aliases -show-encoding \
+# RUN:     | FileCheck -check-prefixes=CHECK-ASM,CHECK-ASM-AND-OBJ %s
----------------
joshua-arch1 wrote:
> craig.topper wrote:
> > I don't like the duplicated test content with rv32zfa-valid.s
> > 
> > I believe our usual MC testing is done like this
> > 
> > rv32zfa-valid.s <- test with both riscv32 and riscv64 command lines.
> > rv32zfa-only-valid.s <- test with riscv32 only instructions that aren't not supported by riscv64
> Thank you for your advice. I'll modify mt testing, but in some MC testing like Zfh and Zfhmin, rv32 and rv64 are tested in separate files. 
I see two test files for zfhmin,  rv32zfhmin-invalid.s  and rv32zfhmin-valid.s. They contain riscv32 and riscv64 RUN lines.

For zfh. At least for the -valid tests. I see rv32zfh-valid.s and rv64zfh-valid.s. The rv32zfh-valid.s file contains riscv32 and riscv64 RUN lines. The rv64zfh-valid.s contains a riscv64 RUN line and instructionst that are specific to riscv64.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140460/new/

https://reviews.llvm.org/D140460