[PATCH] D129735: [RISCV] Add new pass to transform undef to pseudo for vector values.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVRVVInitUndef.cpp:39
+#include "llvm/CodeGen/MachineFunctionPass.h"
+#include <map>
+using namespace llvm;
----------------
Are there any maps in the code anymore?


================
Comment at: llvm/test/CodeGen/RISCV/O3-pipeline.ll:109
 ; CHECK-NEXT:       RISCV Insert VSETVLI pass
+; CHECK-NEXT:       RISCV init undef pass
 ; CHECK-NEXT:       Detect Dead Lanes
----------------
If I understand correctly, we're effectively running DetectDeadLanes inside of RISCV init undef pass and then running the real DetectDeadLanes pass which won't do anything because we already did it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129735/new/

https://reviews.llvm.org/D129735