[PATCH] D140747: [Transform] Rewrite LowerSwitch using APInt

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

a couple of minor style comments



================
Comment at: llvm/lib/Transforms/Utils/LowerSwitch.cpp:461
+      APInt N = High - Low + 1;
+      assert(N.sge(SignedZero));
+      // Explict insert to make sure the bitwidth of APInts match
----------------
(style) assert message


================
Comment at: llvm/lib/Transforms/Utils/LowerSwitch.cpp:489
     // cases.
-    assert(MaxPop > 0 && PopSucc);
+    assert(MaxPop.sgt(SignedZero) && PopSucc);
     Default = PopSucc;
----------------
(style) Assert message


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140747/new/

https://reviews.llvm.org/D140747