[PATCH] D140898: [llvm-exegesis] Remove functional test from unit tests

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 08:19:16 PST 2023


gchatelet created this revision.
gchatelet added reviewers: courbet, rupprecht.
Herald added a subscriber: mstojanovic.
Herald added a project: All.
gchatelet requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

As discussed offline, let's remove this one as it's hard to test on the build bots.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140898

Files:
  llvm/unittests/tools/llvm-exegesis/CMakeLists.txt
  llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp


Index: llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp
===================================================================
--- llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp
+++ /dev/null
@@ -1,42 +0,0 @@
-//===-- PerfHelperTest.cpp --------------------------------------*- C++ -*-===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-#include "PerfHelper.h"
-#include "llvm/Config/config.h"
-#include "gmock/gmock.h"
-#include "gtest/gtest.h"
-
-namespace llvm {
-namespace exegesis {
-namespace pfm {
-namespace {
-
-using ::testing::IsEmpty;
-using ::testing::Not;
-
-TEST(PerfHelperTest, FunctionalTest) {
-#ifdef HAVE_LIBPFM
-  ASSERT_FALSE(pfmInitialize());
-  PerfEvent Event("CYCLES:u");
-  ASSERT_TRUE(Event.valid());
-  EXPECT_EQ(Event.name(), "CYCLES:u");
-  EXPECT_THAT(Event.getPfmEventString(), Not(IsEmpty()));
-  Counter Cnt(std::move(Event));
-  Cnt.start();
-  Cnt.stop();
-  Cnt.read();
-  pfmTerminate();
-#else
-  ASSERT_TRUE(pfmInitialize());
-#endif
-}
-
-} // namespace
-} // namespace pfm
-} // namespace exegesis
-} // namespace llvm
Index: llvm/unittests/tools/llvm-exegesis/CMakeLists.txt
===================================================================
--- llvm/unittests/tools/llvm-exegesis/CMakeLists.txt
+++ llvm/unittests/tools/llvm-exegesis/CMakeLists.txt
@@ -14,7 +14,6 @@
 set(exegesis_sources
   BenchmarkRunnerTest.cpp
   ClusteringTest.cpp
-  PerfHelperTest.cpp
   ProgressMeterTest.cpp
   RegisterValueTest.cpp
   )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140898.486003.patch
Type: text/x-patch
Size: 1721 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230103/f2adea34/attachment.bin>


More information about the llvm-commits mailing list